Add tests for nil *Resource #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
Aneurysm9,
dashpole,
evantorrie,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2227 +/- ##
=====================================
Coverage 72.3% 72.4%
=====================================
Files 168 168
Lines 11832 11835 +3
=====================================
+ Hits 8566 8580 +14
+ Misses 3030 3021 -9
+ Partials 236 234 -2
|
Aneurysm9
approved these changes
Sep 8, 2021
pellared
reviewed
Sep 8, 2021
XSAM
approved these changes
Sep 9, 2021
dashpole
approved these changes
Sep 9, 2021
MrAlias
reviewed
Sep 9, 2021
Co-authored-by: Tyler Yahn <[email protected]>
MrAlias
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a precedent in
sdk/resourcefor allowing anilresource value. One method did not have such a test, and this adds it (along with some tests).